Backend unused code by Artuomka · Pull Request #1749 · rocket-admin/rocketadmin

Artuomka · 2026-04-30T12:34:27Z

Summary by CodeRabbit

Refactoring
- Removed the ability to delete personal table settings via API endpoint
- Eliminated unused database analysis tools and related utility functions
- Cleaned up internal helper functions and message-building convenience methods

Co-authored-by: Copilot <copilot@github.com>

coderabbitai · 2026-04-30T12:34:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b2e2a24-b946-491c-aeb4-f6215940ebf3

📥 Commits

Reviewing files that changed from the base of the PR and between b6a14ea and f4dd4ca.

📒 Files selected for processing (12)

backend/src/ai-core/tools/database-tools.ts
backend/src/ai-core/tools/prompts.ts
backend/src/ai-core/tools/query-validators.ts
backend/src/ai-core/utils/message-builder.ts
backend/src/common/data-injection.tokens.ts
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.controller.ts
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.module.ts
backend/src/entities/table-settings/personal-table-settings/use-cases/delete-personal-table-settings.use.case.ts
backend/src/entities/table-settings/personal-table-settings/use-cases/personal-table-settings.use-cases.interface.ts
backend/src/helpers/app/get-requeired-env-variable.ts
backend/src/helpers/get-master-password.ts
backend/src/helpers/index.ts

💤 Files with no reviewable changes (12)

backend/src/common/data-injection.tokens.ts
backend/src/helpers/app/get-requeired-env-variable.ts
backend/src/helpers/index.ts
backend/src/helpers/get-master-password.ts
backend/src/ai-core/tools/database-tools.ts
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.module.ts
backend/src/ai-core/utils/message-builder.ts
backend/src/entities/table-settings/personal-table-settings/use-cases/delete-personal-table-settings.use.case.ts
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.controller.ts
backend/src/entities/table-settings/personal-table-settings/use-cases/personal-table-settings.use-cases.interface.ts
backend/src/ai-core/tools/query-validators.ts
backend/src/ai-core/tools/prompts.ts

📝 Walkthrough

Walkthrough

This pull request removes eleven exported functions and one enum member across multiple backend modules, including AI core tools, message builders, environment variable helpers, and the personal table settings delete use case along with its supporting interfaces and controller endpoint.

Changes

Cohort / File(s)	Summary
AI Core Tools `backend/src/ai-core/tools/database-tools.ts`, `backend/src/ai-core/tools/prompts.ts`, `backend/src/ai-core/tools/query-validators.ts`	Removes `createTableAnalysisTools()`, `createTableSettingsSystemPrompt()`, and `sanitizeJsonString()` exported functions from AI core modules.
Message Builder Utilities `backend/src/ai-core/utils/message-builder.ts`	Removes `createSimpleMessages()` convenience function while preserving core `MessageBuilder` class functionality.
Personal Table Settings Use Case `backend/src/entities/table-settings/personal-table-settings/use-cases/delete-personal-table-settings.use.case.ts`, `backend/src/entities/table-settings/personal-table-settings/use-cases/personal-table-settings.use-cases.interface.ts`	Deletes entire `DeletePersonalTableSettingsUseCase` implementation class and its corresponding `IDeletePersonalTableSettings` interface contract.
Personal Table Settings Controller & Module `backend/src/entities/table-settings/personal-table-settings/personal-table-settings.controller.ts`, `backend/src/entities/table-settings/personal-table-settings/personal-table-settings.module.ts`	Removes `clearTableSettings()` controller method and DELETE route (`/settings/personal/:connectionId`), along with deletion use case registration and associated middleware.
Dependency Injection & Helpers `backend/src/common/data-injection.tokens.ts`, `backend/src/helpers/app/get-requeired-env-variable.ts`, `backend/src/helpers/get-master-password.ts`, `backend/src/helpers/index.ts`	Removes `DELETE_PERSONAL_TABLE_SETTINGS` enum member, `getOptionalEnvVariable()` and `getMasterPwd()` helper functions, plus their re-exports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

lyubov-voloshko

Poem

🐰 With hopping joy, we prune the code,
Unused paths now shed their load,
No more settings to delete or erase,
Clean and tidy, a tidier place! ✨

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Backend unused code' is vague and generic, using non-descriptive language that doesn't clearly convey the scope or nature of the changes beyond mentioning they relate to backend code cleanup.	Consider a more specific title that describes the primary change, such as 'Remove unused AI tools, helpers, and table settings deletion functionality' or 'Clean up deprecated database analysis and settings management code'.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	Pull request removes unused code with no remaining references in codebase and no broken imports or security implications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch backend_unused_code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR removes unused backend helpers, AI utility functions, and a personal table settings DELETE use case/endpoint to reduce dead code and simplify the backend surface area.

Changes:

Removed unused helpers (getMasterPwd, getOptionalEnvVariable) and related exports.
Removed the personal table settings delete use case, its DI token wiring, and the controller/module DELETE route.
Removed unused AI-core utility functions (createSimpleMessages, sanitizeJsonString, createTableSettingsSystemPrompt, createTableAnalysisTools).

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
backend/src/helpers/index.ts	Removes unused helper export.
backend/src/helpers/get-master-password.ts	Deletes unused helper implementation.
backend/src/helpers/app/get-requeired-env-variable.ts	Removes unused optional env var accessor.
backend/src/entities/table-settings/personal-table-settings/use-cases/personal-table-settings.use-cases.interface.ts	Removes unused delete use case interface.
backend/src/entities/table-settings/personal-table-settings/use-cases/delete-personal-table-settings.use.case.ts	Deletes unused delete use case implementation.
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.module.ts	Removes DELETE use case provider and DELETE route middleware binding.
backend/src/entities/table-settings/personal-table-settings/personal-table-settings.controller.ts	Removes DELETE endpoint and delete use case injection.
backend/src/common/data-injection.tokens.ts	Removes unused DI token for deleted use case.
backend/src/ai-core/utils/message-builder.ts	Removes unused message helper function export.
backend/src/ai-core/tools/query-validators.ts	Removes unused JSON sanitization helper.
backend/src/ai-core/tools/prompts.ts	Removes unused system prompt builder.
backend/src/ai-core/tools/database-tools.ts	Removes unused tool definition builder.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T12:38:25Z

 import {
 	ICreateUpdatePersonalTableSettings,
-	IDeletePersonalTableSettings,
 	IFindPersonalTableSettings,
 } from './use-cases/personal-table-settings.use-cases.interface.js';


After removing the DELETE endpoint/use case, the NestJS Delete decorator import at the top of this controller is now unused (no @Delete usage). Please remove it to keep imports accurate and avoid unused-import lint/knip noise.

Artuomka and others added 3 commits April 30, 2026 08:58

refactor: remove unused delete personal table settings functionality

25d2f8f

Co-authored-by: Copilot <copilot@github.com>

refactor: remove unused table analysis and settings functions

aaf4d67

refactor: remove unused personal table settings functionality and helper

f4dd4ca

Copilot AI review requested due to automatic review settings April 30, 2026 12:34

coderabbitai Bot requested a review from lyubov-voloshko April 30, 2026 12:34

Copilot started reviewing on behalf of Artuomka April 30, 2026 12:35 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Merge branch 'main' into backend_unused_code

2b4fcbe

Artuomka enabled auto-merge April 30, 2026 12:52

Artuomka merged commit 5110e9b into main Apr 30, 2026
18 of 19 checks passed

Artuomka deleted the backend_unused_code branch April 30, 2026 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Backend unused code#1749

Backend unused code#1749
Artuomka merged 4 commits into
mainfrom
backend_unused_code

Artuomka commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Artuomka commented Apr 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 inconclusive)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Artuomka commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading